Repository navigation
fix(wal): retain RPC stage on overall timeouts - #944
Merged
beinan merged 1 commit intoNov 20, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
beinan
marked this pull request as ready for review
November 20, 2026 11:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An overall WAL RPC deadline drops the inner exchange future, so its error context never runs. Timeouts now retain the active RPC stage and peer, distinguishing byte or connection-pool admission, TCP/TLS establishment, response waits, and routing backoff. The original timeout cause, deadline, and unknown-outcome semantics are preserved.
Adds regressions for direct and routed admission/TLS timeouts and extends the pooled-response timeout test to check its stage and retained cause.
Refs #378.
Testing: 51 targeted WAL client tests, service Clippy, and the full local CI script passed. All 21 hosted checks passed at this commit, including the WAL and HA suites.