Skip to content

fix(wal): retain RPC stage on overall timeouts - #944

Merged
beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/wal-rpc-timeout-phase-20261120
Nov 20, 2026
Merged

beinan merged 1 commit into
lance-format:mainfrom
beinan:codex/wal-rpc-timeout-phase-20261120

Conversation

@beinan

@beinan beinan commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

An overall WAL RPC deadline drops the inner exchange future, so its error context never runs. Timeouts now retain the active RPC stage and peer, distinguishing byte or connection-pool admission, TCP/TLS establishment, response waits, and routing backoff. The original timeout cause, deadline, and unknown-outcome semantics are preserved.

Adds regressions for direct and routed admission/TLS timeouts and extends the pooled-response timeout test to check its stage and retained cause.

Refs #378.

Testing: 51 targeted WAL client tests, service Clippy, and the full local CI script passed. All 21 hosted checks passed at this commit, including the WAL and HA suites.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ance-context-wal/src/replication/runtime/client.rs 97.67% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@beinan
beinan marked this pull request as ready for review November 20, 2026 11:51
@beinan
beinan merged commit 2e6a651 into lance-format:main Nov 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants